zitadel icon indicating copy to clipboard operation
zitadel copied to clipboard

refactor(query): use new packages for org by id query

Open adlerhurst opened this issue 1 year ago • 1 comments

If the feature is enabled the new packages are used to query org by id

This PR includes the changes of https://github.com/zitadel/zitadel/pull/7823 merge the successor first before you start reviewing this PR.

Part of: https://github.com/zitadel/zitadel/issues/7639

Definition of Ready

  • [x] I am happy with the code
  • [x] Short description of the feature/issue is added in the pr description
  • [ ] PR is linked to the corresponding user story
  • [ ] Acceptance criteria are met
  • [ ] All open todos and follow ups are defined in a new ticket and justified
  • [ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • [x] No debug or dead code
  • [x] My code has no repetitions
  • [ ] Critical parts are tested automatically
  • [ ] Where possible E2E tests are implemented
  • [ ] Documentation/examples are up-to-date
  • [ ] All non-functional requirements are met
  • [x] Functionality of the acceptance criteria is checked manually on the dev system.

adlerhurst avatar Apr 22 '24 14:04 adlerhurst

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 10:22am

vercel[bot] avatar Apr 22 '24 14:04 vercel[bot]

Codecov Report

Attention: Patch coverage is 34.09836% with 201 lines in your changes are missing coverage. Please review.

Project coverage is 62.10%. Comparing base (e58869c) to head (5b94e0f).

Files Patch % Lines
internal/v2/projection/org_state.go 0.00% 40 Missing :warning:
internal/v2/readmodel/org.go 0.00% 33 Missing :warning:
internal/v2/projection/org_primary_domain.go 0.00% 29 Missing :warning:
internal/query/org.go 20.68% 23 Missing :warning:
internal/command/system_features_model.go 41.66% 18 Missing and 3 partials :warning:
internal/api/grpc/feature/v2/converter.go 55.55% 16 Missing :warning:
internal/command/instance_features_model.go 66.66% 10 Missing and 1 partial :warning:
internal/query/instance_features_model.go 61.11% 7 Missing :warning:
internal/query/system_features_model.go 56.25% 6 Missing and 1 partial :warning:
internal/v2/projection/projection.go 0.00% 7 Missing :warning:
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7826      +/-   ##
==========================================
- Coverage   62.19%   62.10%   -0.10%     
==========================================
  Files        1380     1386       +6     
  Lines      111548   111771     +223     
==========================================
+ Hits        69374    69411      +37     
- Misses      38284    38468     +184     
- Partials     3890     3892       +2     
Flag Coverage Δ
core-integration-tests-postgres 62.10% <34.09%> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 24 '24 10:05 codecov[bot]

:tada: This PR is included in version 2.53.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] avatar May 28 '24 13:05 github-actions[bot]