typescript icon indicating copy to clipboard operation
typescript copied to clipboard

fix: use /ui/v2/login as default base path

Open eliobischof opened this issue 10 months ago • 2 comments

If NEXT_PUBLIC_BASE_PATH is unset, we default to /ui/v2/login. This makes it easier to set up self-hosted Zitadel with the login.

Next falls throug to the .env file if a variable is not configured in a different way

Definition of Ready

  • [x] I am happy with the code
  • [x] Short description of the feature/issue is added in the pr description
  • [ ] PR is linked to the corresponding user story
  • [x] Acceptance criteria are met
  • [x] All open todos and follow ups are defined in a new ticket and justified
  • [x] Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • [x] Vitest unit tests ensure that components produce expected outputs on different inputs.
  • [x] Cypress integration tests ensure that login app pages work as expected on good and bad user inputs, ZITADEL responses or IDP redirects. The ZITADEL API is mocked, IDP redirects are simulated.
  • [x] Playwright acceptances tests ensure that the happy paths of common user journeys work as expected. The ZITADEL API is not mocked but IDP redirects are simulated.
  • [x] No debug or dead code
  • [x] My code has no repetitions

eliobischof avatar Feb 28 '25 14:02 eliobischof

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typescript-login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 3:09pm

vercel[bot] avatar Feb 28 '25 14:02 vercel[bot]

@peintnermax do you have an idea why the integration tests fail? I tried many things already, nothing helped (see commits). I can run the login on / though.

eliobischof avatar Feb 28 '25 15:02 eliobischof