oidc icon indicating copy to clipboard operation
oidc copied to clipboard

Feature/support dynamic registration management rfc7591 rfc7592 #1

Open mqf20 opened this issue 4 months ago • 5 comments

Resolves https://github.com/zitadel/oidc/issues/763

Definition of Ready

  • [x] I am happy with the code
  • [x] Short description of the feature/issue is added in the pr description
  • [x] PR is linked to the corresponding user story
  • [ ] Acceptance criteria are met
  • [ ] All open todos and follow ups are defined in a new ticket and justified
  • [ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
  • [ ] No debug or dead code
  • [ ] My code has no repetitions
  • [ ] Critical parts are tested automatically
  • [ ] Where possible E2E tests are implemented
  • [ ] Documentation/examples are up-to-date
  • [ ] All non-functional requirements are met
  • [ ] Functionality of the acceptance criteria is checked manually on the dev system.

mqf20 avatar Aug 10 '25 09:08 mqf20

Heya @mqf20 thanks for your contribution - we'll review this as soon as we can, currently working through a lot of contributions.

elinashoko avatar Aug 11 '25 07:08 elinashoko

This PR only adds the routes in op.go, but not in http_server.go. I don't know why there are two routers with separate handler functions, but Zitadel seems to use http_server.go. Otherwise, when configuring a registration endpoint, Zitadel only returns 404 on the advertised registration endpoint. I used this commit to add the route to http_server.go, which works: https://github.com/famedly/zitadel-oidc/commit/a38fab7b77cdf844fd68ebf3cdcc6390034140da This commit implements the new interface in Zitadel: https://github.com/famedly/zitadel/commit/c747723a502f88f78a74bef85677dab92adc169f

Is there a way to use the existing interface (ClientsStorage) in Zitadel? Otherwise, all routes should also be added to http_server.go.

lukaslihotzki-f avatar Aug 13 '25 13:08 lukaslihotzki-f

Please take note of https://github.com/zitadel/oidc/discussions/785

muhlemmer avatar Aug 19 '25 11:08 muhlemmer

Please take note of #785

@muhlemmer any chance this PR can be looked at in an upcoming sprint?

mqf20 avatar Sep 28 '25 13:09 mqf20

This PR only adds the routes in op.go, but not in http_server.go. I don't know why there are two routers with separate handler functions, but Zitadel seems to use http_server.go. Otherwise, when configuring a registration endpoint, Zitadel only returns 404 on the advertised registration endpoint. I used this commit to add the route to http_server.go, which works: famedly@a38fab7 This commit implements the new interface in Zitadel: famedly/zitadel@c747723

Is there a way to use the existing interface (ClientsStorage) in Zitadel? Otherwise, all routes should also be added to http_server.go.

@lukaslihotzki-f do you mean all routes should be added to server_http.go (instead of http_server.go)?

Also, will you be submitting a PR for your fix?

mqf20 avatar Sep 28 '25 13:09 mqf20