zirain

Results 383 comments of zirain

> > It needs a LOT of clear info for operators - we understand what it does, > > TBH I don't :-) whats the difference between rotation and deletion?...

> Examples ? What is deleted, all metrics, some ? I think I understand - but I am not sure. We can't ask users to read envoy c++ code to...

> Not 'Prometheus scrape interval' - a pod may be scraped by multiple tools. TBH, I don't how to set a correct value for this scenario > My suggestion is...

> The real problem with this feature - which is IMO a great solution to high cardinality - is the lack of practice/visibility/adoption - it relies on an openmetrics protocol...

> I had a chat with few Google telemetry people - the suggestion was to be very careful and use large values ( hours - days ), and will likely...

the root cause of this is the first line of generated crd file? https://github.com/envoyproxy/gateway/blob/975ef6e8498e1fda635cf70d477c7370093fb645/charts/gateway-helm/crds/generated/gateway.envoyproxy.io_backendtrafficpolicies.yaml#L1 these files generated by `controller-gen`, so I think jsonnet should fix this?

I assume it cames from https://github.com/kubernetes-sigs/controller-tools/blob/b3fa06ca438431f4e4777b2f29c8b6257f478c71/pkg/genall/genall.go#L162 correct me if I'm wrong.

TBH, I'm not sure where's the root cause, controller-gen, helm or Jsonnet.