hf-multitask-trainer icon indicating copy to clipboard operation
hf-multitask-trainer copied to clipboard

Fix misaligned arguments in super() constructor call

Open bauwenst opened this issue 1 year ago • 2 comments

Fixes https://github.com/zipzou/hf-multitask-trainer/issues/5 by adding keyword arguments to the constructor. Also did some minor refactoring.

bauwenst avatar Dec 09 '24 14:12 bauwenst

Good job!! But I think it is better that all the codes are reformatted with yapf according to the .style.cfg. This could reduce the diff and keep the style consistent with before.

Well, I would pull these changes, reformat and review them later. If you have more free time to reformat codes, just make a new submission or PR.

Thanks for your time!

zipzou avatar Dec 15 '24 07:12 zipzou

I think it is better that all the codes are reformatted with yapf according to the .style.cfg. This could reduce the diff and keep the style consistent with before.

I see. I don't use this reformatting tool, and instead I try to manually adhere to the usual style used by the HuggingFace team. I have to admit that some of the formatting in your code is quite strange to me (e.g. using three lines for simple function calls), to the point that I've never seen anyone style Python like it. It reminds me of Java, but Python is not Java ;-)

Up to you how you want to resolve this. I'm obviously not going to re-format code in a style I don't know :P

bauwenst avatar Dec 15 '24 15:12 bauwenst