zio-telemetry icon indicating copy to clipboard operation
zio-telemetry copied to clipboard

Published 20 hours ago • verified publisher icon zio

Backport OTEL autoinstrumentation from series/2.x

Open grouzen opened this issue 2 years ago • 6 comments

grouzen avatar Feb 16 '23 14:02 grouzen

Hi @grouzen,

As of today, PropagatingSupervisor is not needed any more, because ZIO 2.0 instrumentation has landed in OpenTelemetry Java Agent v1.25.0 (release notes). We should remove it from series 2 and 3 as well. I could look into this when I have some spare time.

dmytr avatar Apr 14 '23 07:04 dmytr

Hi @dmytr!

It is nice to hear. Thanks for your contribution!

I'm also still working on adding an example of how to use auto instrumentation, but I'm failing to make it work with Jaeger. Can I ask you to help me with this when you have time?

grouzen avatar Apr 18 '23 12:04 grouzen

Hi @grouzen,

I've done a bit of clean up to remove now obsolete PropagatingSupervisor in https://github.com/zio/zio-telemetry/pull/681.

Seems like it would be relevant for this PR.

dmytr avatar May 06 '23 12:05 dmytr

Thanks! Yeah, I'll update this PR after we merge yours.

grouzen avatar May 06 '23 15:05 grouzen

It seems we still need to keep PropagatingSupervisor you implemented for series/1.x since java-insturmentation supports zio2 only.

grouzen avatar May 23 '23 09:05 grouzen

Oh right... :disappointed:

dmytr avatar May 23 '23 14:05 dmytr