zio-sqs icon indicating copy to clipboard operation
zio-sqs copied to clipboard

Published 20 hours ago • verified publisher icon zio

#259: Added function to allow processing messages at least once

Open V-Lamp opened this issue 1 year ago • 5 comments

V-Lamp avatar May 23 '23 21:05 V-Lamp

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 23 '23 21:05 CLAassistant

Is it not possible to test it with elasticmq?

Also, the CI is failing, please check linting and compile errors 🙏

ghostdogpr avatar May 24 '23 00:05 ghostdogpr

Tests with localstack pass in a few seconds and is the de facto standard in testing AWS, so happy to provide this instead (lower effort as I have it working) and will benefit other tests in here eventually 🙂

I will add the tests, and that will fix any issues, I just shared the idea to see if it indeed fits the needs of the use case before I progress further

V-Lamp avatar May 24 '23 08:05 V-Lamp

I think it would be better for maintainability if all tests used the same backend (whether it's localstack or elasticmq) 😄

Regarding the original idea, I haven't used SQS since 2019 so I don't have much opinions on this anymore, I suggest you ask opinion on the zio Discord, there is a channel for zio-sqs and you might find other users there 👍

ghostdogpr avatar May 24 '23 08:05 ghostdogpr

I have also left a comment in testcontainers-for-zio on this btw: https://github.com/scottweaver/testcontainers-for-zio/pull/41#issuecomment-1555972627

I see what you mean, I would expect it to be easy to transition tests to localstack given that ultimately all that is needed is a Layer providing a zio.aws.sqs.Sqs

V-Lamp avatar May 24 '23 08:05 V-Lamp