zio-schema
zio-schema copied to clipboard
Add phone number validations for European countries
ISSUE
There is no constructor for zio.schema.validation.Validation
which can validate a European country phone number.
NOTE: This is 50 tickets in one. Please signup for one or more of the tickets by checking them below.
- [ ] Albania
- [ ] Andorra
- [ ] Armenia
- [ ] Austria
- [ ] Azerbaijan
- [ ] Belarus
- [ ] Belgium
- [ ] Bosnia and Herzegovina
- [ ] Bulgaria
- [ ] Croatia
- [ ] Cyprus
- [ ] Czechia
- [ ] Denmark
- [ ] Estonia
- [ ] Finland
- [ ] France
- [ ] Georgia
- [ ] Germany
- [ ] Greece
- [ ] Hungary
- [ ] Iceland
- [ ] Ireland
- [ ] Italy
- [ ] Kazakhstan
- [ ] Kosovo
- [ ] Latvia
- [ ] Liechtenstein
- [ ] Lithuania
- [ ] Luxembourg
- [ ] Malta
- [ ] Moldova
- [ ] Monaco
- [ ] Montenegro
- [ ] Netherlands
- [ ] North Macedonia
- [ ] Norway
- [ ] Poland
- [ ] Portugal
- [ ] Romania
- [ ] Russia
- [ ] San Marino
- [ ] Serbia
- [ ] Slovakia
- [ ] Slovenia
- [ ] Spain
- [ ] Sweden
- [ ] Switzerland
- [ ] Turkey
- [ ] Ukraine
- [ ] Vatican City (Holy See)
SOLUTION
Using other constructors which already exist in zio.schema.validation.Validation
(which include regex validation, string length checking, and numeric range checking), introduce a new constructor that satisfies the requirements of this issue.
object Validation {
...
val phoneNumber<2-Letter CountryCode>: Validation[String] = ???
}
IMPACT
Increasing the number of constructors for Validation
will make it far easier to use the validation
package to
WHERE TO LOOK
PROBLEMATIC ISSUES
Issue #248 must be completed first, or at least, this issue must be based off of #244.
I'll try to get that one started by implementing Switzerland, but once I got the hang of it, I can continue with other countries too.
I'll try to get into this as well and will start with Germany.
@marioaae should we pair up, maybe? If you want to, just ping me on discord (I posted in the zio-schema channel, so you should easily be able to find me)
I will try Serbia.
I will try Portugal.
I will do Hungary.
This ticket needs to be updated to reflect which validators have already been implemented, and which remain.
I can't update the initial task, but I went through the list: all of the validations (and many more) are done, so this issue can be closed, I suppose.
(Only thing I noticed, in the comment the republic of North Macedonia is referred to as the republic of Macedonia, which isn't the official name any more.)