zio-quill icon indicating copy to clipboard operation
zio-quill copied to clipboard

Scala Native support

Open lolgab opened this issue 5 years ago • 7 comments

Initial Scala Native support for quill-core and quill-sql modules. There is no Scalatest 3.0.x for Scala Native so I used 3.1.0-SNAP7 for Scala Native and old Scalatest for JVM and JS platforms ( default technique to port to Scala Native)

Notes

Ignored a test folder on native only because of a bug of Scala Native triggered by a test. Did it with this sbt setting:

Test / sources :=
  (Test / sources).value
    .filterNot { s =>
      val path = s.getPath
      path.contains("src/test/scala/io/getquill/monad/")
  }

@getquill/maintainers

lolgab avatar Mar 10 '19 13:03 lolgab

Checked out this branch and updated build in #1443.

deusaquilus avatar May 23 '19 06:05 deusaquilus

I think we should wait to merge because they are releasing Scala Native 0.4.0-M1 and we can do a crossbuild to support both 0.4.x and 0.3.x using some environmental variable like scala-js does for cross build to 0.6 and 1.0.

lolgab avatar May 23 '19 11:05 lolgab

@lolgab It's failing on -Xms1024m. Any idea how this parameter is supposed to be specified for Scala Native?

deusaquilus avatar May 23 '19 12:05 deusaquilus

@lolgab It's failing on -Xms1024m. Any idea how this parameter is supposed to be specified for Scala Native?

I'm not aware of any Scala Native specific problem.

lolgab avatar May 23 '19 13:05 lolgab

@lolgab That's really odd. The build fails in quill-core with the following:

[error] Expected symbol
[error] Not a valid command: -
[error] Expected end of input.
[error] Expected '--'
[error] Expected 'debug'
[error] Expected 'info'
[error] Expected 'warn'
[error] Expected 'error'
[error] Expected 'addPluginSbtFile'
[error] -Xms1024m
[error]  ^

This is the line it doesn't like:

/home/travis/.sbt/launchers/1.2.8/sbt-launch.jar
-Xms1024m     <- *** Problem happens here ***
-Xmx3g
-Xss5m
-XX:ReservedCodeCacheSize=256m
-XX:+TieredCompilation
-XX:+CMSClassUnloadingEnabled
-XX:+UseConcMarkSweepGC
++2.11.12
coverage
test

Have you ever seen this issue before?

deusaquilus avatar May 23 '19 13:05 deusaquilus

Add -J, e.g. -J-Xms1024m.

dwijnand avatar May 23 '19 17:05 dwijnand

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: lolgab
:x: Lorenzo Gabriele


Lorenzo Gabriele seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 24 '22 22:01 CLAassistant