zio-http icon indicating copy to clipboard operation
zio-http copied to clipboard

Published 20 hours ago • verified publisher icon zio

Client default User Agent request header

Open gciuloaica opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe. There are many REST APIs that are mandating http clients to provide a proper User Agent request header. One of those APIs is Github API that reject the request that do not provide a valid User Agent request header with each request.

Describe the solution you'd like ZIO Http client should provide a default value for User Agent request header, following the recommendations from Http 1.1 Specification

gciuloaica avatar Dec 23 '21 15:12 gciuloaica

Can I take this?

rajcspsg avatar Dec 28 '21 05:12 rajcspsg

Yes please!

tusharmath avatar Feb 06 '22 01:02 tusharmath

Hi @tusharmath

I'm planning to set the default user-agent as Zio-Http-Client ${zio-http-jar-version} Scala ${scala-version}.

please let me know your feedback.

rajcspsg avatar Apr 01 '22 04:04 rajcspsg

Hi @tusharmath

I'm planning to set the default user-agent as Zio-Http-Client ${zio-http-jar-version} Scala ${scala-version}.

please let me know your feedback.

Looks good to me

amitksingh1490 avatar Apr 02 '22 07:04 amitksingh1490