zio-http icon indicating copy to clipboard operation
zio-http copied to clipboard

Add brotli compression (#2646)

Open 987Nabil opened this issue 2 years ago • 3 comments

@jdegoes I think the brotli4j dependency is okay. It would go to the netty backend module once we split zio-http core and netty backend.

fixes #2646 /claim #2646

987Nabil avatar Feb 08 '24 21:02 987Nabil

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (21989c9) 64.55% compared to head (838430c) 64.44%.

Files Patch % Lines
...o-http/shared/src/main/scala/zio/http/Server.scala 35.71% 9 Missing :warning:
.../main/scala/zio/http/netty/model/Conversions.scala 28.57% 5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2673      +/-   ##
==========================================
- Coverage   64.55%   64.44%   -0.11%     
==========================================
  Files         145      145              
  Lines        8607     8620      +13     
  Branches     1521     1532      +11     
==========================================
- Hits         5556     5555       -1     
- Misses       3051     3065      +14     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 08 '24 21:02 codecov-commenter

@jdegoes I am not sure what the problem with the shading is. Never had to configure it before. Can you give me a hint? The build error is not very helpful.

987Nabil avatar Feb 09 '24 17:02 987Nabil

@987Nabil I have not used that setting before, I just know why it's used and how it works.

jdegoes avatar Feb 14 '24 09:02 jdegoes

@987Nabil Please re-open when build is passing. 🙏

jdegoes avatar Apr 16 '24 16:04 jdegoes