zio-http icon indicating copy to clipboard operation
zio-http copied to clipboard

Remove event loop

Open gciuloaica opened this issue 1 year ago • 1 comments

gciuloaica avatar Aug 10 '22 09:08 gciuloaica

Codecov Report

Merging #1387 (1379c3d) into main (a4fafae) will increase coverage by 0.16%. The diff coverage is 52.30%.

@@            Coverage Diff             @@
##             main    #1387      +/-   ##
==========================================
+ Coverage   61.13%   61.29%   +0.16%     
==========================================
  Files          71       71              
  Lines        2470     2470              
  Branches       93       89       -4     
==========================================
+ Hits         1510     1514       +4     
+ Misses        960      956       -4     
Impacted Files Coverage Δ
...io-http/src/main/scala/zhttp/service/package.scala 100.00% <ø> (ø)
.../src/main/scala/zhttp/service/ChannelFactory.scala 46.66% <40.00%> (+13.33%) :arrow_up:
.../src/main/scala/zhttp/service/EventLoopGroup.scala 36.84% <40.00%> (+16.84%) :arrow_up:
...la/zhttp/service/server/ServerChannelFactory.scala 41.66% <41.66%> (+25.00%) :arrow_up:
zio-http/src/main/scala/zhttp/service/Server.scala 48.10% <57.57%> (-1.22%) :arrow_down:
zio-http/src/main/scala/zhttp/service/Client.scala 89.83% <75.00%> (-2.36%) :arrow_down:
...o-http/src/main/scala/zhttp/socket/SocketApp.scala 75.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 10 '22 09:08 codecov-commenter

Different approach was suggested

gciuloaica avatar Sep 05 '22 12:09 gciuloaica