zio-http icon indicating copy to clipboard operation
zio-http copied to clipboard

Fix for #1372 - Host header must include port

Open paul-lysak opened this issue 1 year ago • 2 comments

Fix for https://github.com/dream11/zio-http/issues/1372 - according to HTTP 1.1 spec (https://datatracker.ietf.org/doc/html/rfc2616#section-14.23) Host header must include port if the request is sent to the custom port

paul-lysak avatar Jul 28 '22 08:07 paul-lysak

Run scalafmt once on your code.

tusharmath avatar Jul 31 '22 12:07 tusharmath

Codecov Report

Merging #1373 (d71277e) into main (66b571c) will increase coverage by 0.59%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1373      +/-   ##
==========================================
+ Coverage   60.79%   61.39%   +0.59%     
==========================================
  Files          71       71              
  Lines        2482     2497      +15     
  Branches       84       76       -8     
==========================================
+ Hits         1509     1533      +24     
+ Misses        973      964       -9     
Impacted Files Coverage Δ
zio-http/src/main/scala/zhttp/service/Client.scala 92.18% <100.00%> (ø)
...p/src/main/scala/zhttp/service/EncodeRequest.scala 100.00% <100.00%> (ø)
.../scala/zhttp/service/server/WebSocketUpgrade.scala 55.55% <0.00%> (-33.34%) :arrow_down:
...io-http/src/main/scala/zhttp/service/Handler.scala 68.75% <0.00%> (-5.17%) :arrow_down:
...la/zhttp/service/server/ServerChannelFactory.scala 16.66% <0.00%> (-1.52%) :arrow_down:
...main/scala/zhttp/http/headers/HeaderModifier.scala 17.44% <0.00%> (-1.17%) :arrow_down:
.../src/main/scala/zhttp/service/EventLoopGroup.scala 20.00% <0.00%> (-1.06%) :arrow_down:
...main/scala/zhttp/service/WebSocketAppHandler.scala 76.92% <0.00%> (-0.86%) :arrow_down:
.../main/scala/zhttp/http/headers/HeaderGetters.scala 32.52% <0.00%> (-0.82%) :arrow_down:
...ttp/src/main/scala/zhttp/service/HttpRuntime.scala 86.20% <0.00%> (-0.46%) :arrow_down:
... and 20 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jul 31 '22 12:07 codecov-commenter

@tusharmath @amitksingh1490 can you please run the CI? It's been 2 weeks since I've committed the latest fixes

paul-lysak avatar Aug 25 '22 06:08 paul-lysak

Build and Test (ubuntu-latest, 2.12.15, temurin@8) Expected — Waiting for status to be reported - @tusharmath - should I rebase to the fresh code from the main branch to have test environment versions updated?

paul-lysak avatar Aug 26 '22 13:08 paul-lysak