zio-http
zio-http copied to clipboard
issue_685 Client default User Agent request header
this closes the issue https://github.com/dream11/zio-http/issues/685
Codecov Report
Merging #1181 (63db867) into main (90a26a9) will increase coverage by
0.14%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
+ Coverage 60.45% 60.60% +0.14%
==========================================
Files 71 71
Lines 2526 2533 +7
Branches 82 81 -1
==========================================
+ Hits 1527 1535 +8
+ Misses 999 998 -1
Impacted Files | Coverage Δ | |
---|---|---|
zio-http/src/main/scala/zhttp/service/Client.scala | 92.95% <100.00%> (+0.77%) |
:arrow_up: |
zio-http/src/main/scala/zhttp/http/Headers.scala | 90.90% <0.00%> (+4.54%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 90a26a9...63db867. Read the comment docs.
This looks good @rajcspsg !
Could you please add some unit tests also for this.
This looks good @rajcspsg !
Could you please add some unit tests also for this.
@tusharmath could you please provide the link for existing test cases for http client. I tried to find but couldn't
This looks good @rajcspsg ! Could you please add some unit tests also for this.
@tusharmath could you please provide the link for existing test cases for http client. I tried to find but couldn't @rajcspsg Please check this https://github.com/dream11/zio-http/blob/main/zio-http/src/test/scala/zhttp/service/ClientSpec.scala
@amitksingh1490 @tusharmath I've added unit test. could you please check again.
@tusharmath @amitksingh1490 could you please take a look at the PR and let me know in case if any update needed.
@tusharmath @amitksingh1490 could you please take a look at the PR and let me know in case if any update needed.
@tusharmath @amitksingh1490 could you please take a look at this PR when you get chance.
@tusharmath @amitksingh1490 I've fixed the merge conflicts. Could you please check the PR once again
@tusharmath @amitksingh1490 I've fixed the merge conflicts. Could you please check the PR once again
@rajcspsg could you sign the Contributor License Agreement?
@vigoo Thanks I've signed the contributor agreement
thanks!
Merging this because the concerns seems to be solved and the client interface is being redesigned in another PR anyway.