zio-http icon indicating copy to clipboard operation
zio-http copied to clipboard

issue_685 Client default User Agent request header

Open rajcspsg opened this issue 2 years ago • 9 comments

this closes the issue https://github.com/dream11/zio-http/issues/685

rajcspsg avatar Apr 02 '22 21:04 rajcspsg

Codecov Report

Merging #1181 (63db867) into main (90a26a9) will increase coverage by 0.14%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1181      +/-   ##
==========================================
+ Coverage   60.45%   60.60%   +0.14%     
==========================================
  Files          71       71              
  Lines        2526     2533       +7     
  Branches       82       81       -1     
==========================================
+ Hits         1527     1535       +8     
+ Misses        999      998       -1     
Impacted Files Coverage Δ
zio-http/src/main/scala/zhttp/service/Client.scala 92.95% <100.00%> (+0.77%) :arrow_up:
zio-http/src/main/scala/zhttp/http/Headers.scala 90.90% <0.00%> (+4.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90a26a9...63db867. Read the comment docs.

codecov-commenter avatar Apr 02 '22 21:04 codecov-commenter

This looks good @rajcspsg !

Could you please add some unit tests also for this.

tusharmath avatar Apr 15 '22 07:04 tusharmath

This looks good @rajcspsg !

Could you please add some unit tests also for this.

@tusharmath could you please provide the link for existing test cases for http client. I tried to find but couldn't

rajcspsg avatar Apr 15 '22 07:04 rajcspsg

This looks good @rajcspsg ! Could you please add some unit tests also for this.

@tusharmath could you please provide the link for existing test cases for http client. I tried to find but couldn't @rajcspsg Please check this https://github.com/dream11/zio-http/blob/main/zio-http/src/test/scala/zhttp/service/ClientSpec.scala

amitksingh1490 avatar Apr 15 '22 07:04 amitksingh1490

@amitksingh1490 @tusharmath I've added unit test. could you please check again.

rajcspsg avatar Apr 16 '22 03:04 rajcspsg

@tusharmath @amitksingh1490 could you please take a look at the PR and let me know in case if any update needed.

rajcspsg avatar Jun 28 '22 14:06 rajcspsg

@tusharmath @amitksingh1490 could you please take a look at the PR and let me know in case if any update needed.

@tusharmath @amitksingh1490 could you please take a look at this PR when you get chance.

rajcspsg avatar Jul 06 '22 03:07 rajcspsg

@tusharmath @amitksingh1490 I've fixed the merge conflicts. Could you please check the PR once again

rajcspsg avatar Jul 21 '22 04:07 rajcspsg

@tusharmath @amitksingh1490 I've fixed the merge conflicts. Could you please check the PR once again

rajcspsg avatar Jul 25 '22 20:07 rajcspsg

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 15 '22 12:09 CLAassistant

@rajcspsg could you sign the Contributor License Agreement?

vigoo avatar Sep 15 '22 12:09 vigoo

@vigoo Thanks I've signed the contributor agreement

rajcspsg avatar Sep 15 '22 13:09 rajcspsg

thanks!

vigoo avatar Sep 15 '22 13:09 vigoo

Merging this because the concerns seems to be solved and the client interface is being redesigned in another PR anyway.

vigoo avatar Sep 15 '22 13:09 vigoo