zio-connect icon indicating copy to clipboard operation
zio-connect copied to clipboard

initial code

Open kyw-iduce opened this issue 2 years ago • 3 comments

I still need to add tests. But l want us to discuss the design first.

kyw-iduce avatar Nov 21 '22 00:11 kyw-iduce

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 21 '22 00:11 CLAassistant

@kyw-iduce I think you can do iterative PR's here. For instance we could merge this without having the connector active (still need to solve conflicts here though). And make a different issue about making the tests using testcontainers. It doesn't always have to be done in a single PR.

adrianfilip avatar Dec 11 '22 08:12 adrianfilip

@kyw-iduce I think you can do iterative PR's here. For instance we could merge this without having the connector active (still need to solve conflicts here though). And make a different issue about making the tests using testcontainers. It doesn't always have to be done in a single PR.

Sounds good.

kyw-iduce avatar Dec 11 '22 14:12 kyw-iduce