graphql-flutter icon indicating copy to clipboard operation
graphql-flutter copied to clipboard

Use sdk version constraints to better manage api changes

Open micimize opened this issue 5 years ago • 9 comments

Problem

We had an issue where dart:ui changed the AppLifecycleState api, breaking our library. The way we discovered this was through an issue, and because of our lack of metadata around compatible sdk versions, we were forced to overly generalize with #475

Solution

This will take a little investigation, but will probably look something like

  • [ ] better constrain version number
  • [ ] implement some maintainer process for testing new sdk releases (dart lang, ui, flutter)

micimize avatar Nov 18 '19 14:11 micimize

    Compiler message:
    ../../flutter/.pub-cache/hosted/pub.dartlang.org/graphql_flutter-2.1.1-beta.3/lib/src/widgets/cache_provider.dart:64:30: Error: Getter not found: 'suspending'.
          case AppLifecycleState.suspending:
                                 ^^^^^^^^^^
    Exception: Errors during snapshot creation: null
    #0      KernelSnapshot.build (package:flutter_tools/src/build_system/targets/dart.dart:231:7)
    <asynchronous suspension>
    #1      _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart:526:25)

lookfirst avatar Nov 19 '19 10:11 lookfirst

Next version doesn't seem to be on pub yet.

lookfirst avatar Nov 19 '19 10:11 lookfirst

The latest dev release was 2.1.1-beta.3 on Nov 13, 2019.

lookfirst avatar Nov 19 '19 10:11 lookfirst

@micimize Hey! Please update pub.

lookfirst avatar Nov 20 '19 11:11 lookfirst

This has been done. Thanks!

lookfirst avatar Nov 23 '19 06:11 lookfirst

@lookfirst please don't spam threads with effectively the same comment over and over, on this or other projects. No FOSS maintainer owes you their time. You could have just used a git dependency to work around this.

micimize avatar Nov 23 '19 17:11 micimize

A follow up comment after a few weeks of inactivity would have been appropriate in this case

micimize avatar Nov 23 '19 17:11 micimize

I wasn't expecting your time. I was trying to let others know to not waste their time trying to figure out what was wrong when their compile suddenly broke and hopefully notify you that you forgot to push the release to pub. Notice the thumbs up above?

A little advice from someone who's been doing OSS for over 25 years now? Chill out on getting upset... that is the only thing not worth your energy. It is just a message on a wall, not spam.

lookfirst avatar Nov 24 '19 05:11 lookfirst

@lookfirst just trying to promoting good OS etiquette. I guess we have different philosophies on what that constitutes.

micimize avatar Nov 24 '19 15:11 micimize