zingolib icon indicating copy to clipboard operation
zingolib copied to clipboard

Published 20 hours ago • verified publisher icon zingolabs

Deprecate Unendorsed Interfaces on the LightClient

Open zancas opened this issue 1 year ago • 2 comments

@juanky201271 has use-cases for these interfaces:

  • start_mempool_monitor
  • new
  • create_from_wallet_base
  • read_wallet_from_buffer
  • create_unconnected
  • init_logging
  • read_wallet_from_disk

@AArnott has used-cases for these interfaces:

  • read_wallet_from_disk
  • create_from_wallet_base_async
  • start_mempool_monitor
  • interrupt_sync_after_batch
  • do_sync_status
  • do_balance
  • do_sync
  • do_send
  • do_send_progress

By manual inspection I see that the union is:

  • start_mempool_monitor
  • new
  • create_from_wallet_base
  • read_wallet_from_buffer
  • create_unconnected
  • init_logging
  • read_wallet_from_disk
  • create_from_wallet_base_async
  • interrupt_sync_after_batch
  • do_sync_status
  • do_balance
  • do_sync
  • do_send
  • do_send_progress

@juanky201271 shouldn't do_shield be on this list?

zancas avatar Oct 28 '23 16:10 zancas