Shielding to address that does not belong to my wallet

[Matti50]

Steps to repro:

1. Have two wallets running in this manner: ./target/release/zingo-cli --server=anyserver --data-dir /path/to/walletA ./target/release/zingo-cli --server=anyserver --data-dir /path/to/walletB

2. Have transparent balance in walletA

3. Standing in walletA, run the command: shield <sapling address of walletB>

I think the outcome of that is you are shielding your own transparent balance to another person's sapling address. Is this expected behaviour?

[AloeareV]

The expected pattern is that 99% of the time, you just run shield and it sends to the orchard pool of your UA. If you want to shield to sapling instead, you can grab your sapling address and paste it in there.

If someone has a use-case where they want to shield transparent funds by sending them to an address in another wallet, that's probably fine..although it might be confusing that shield can be used to send to an external address. Maybe we can add a flag in here that makes sure a shield-to-external is intended.

[pacu]

It's basically sending from T. I don't think it's the idea of Zingo to begin with. Probably a product decision since protocol allows it.