zingolib icon indicating copy to clipboard operation
zingolib copied to clipboard
verified publisher icon zingolabs

ring 0.17.X upgrade

Open juanky201271 opened this issue 1 year ago • 6 comments

In order to build Zingo-pc for windows arm64 I need to upgrade to ring 0.17.x

I need to upgrade BIP0039 from 0.10.1 to 0.11.0 or 0.12.0 in zcash_primitives (https://github.com/zingolabs/librustzcash.git?tag=always_require_change#ae0d477a).

I don't have a clue if this can be a problem in zingolib.

@idky137 Can you help me with that, I hear you have a lot of experience with dependencies...

juanky201271 avatar Aug 06 '24 03:08 juanky201271

Hi @AloeareV is this review ready? It is marked draft.

zancas avatar Aug 18 '24 16:08 zancas

Hi @AloeareV is this review ready? It is marked draft.

Yes, this is review ready! It currently depends on a librustzcash version by commit hash instead of by tag, https://github.com/zingolabs/librustzcash/pull/25 is the PR with the changed librustzcash.

AloeareV avatar Aug 19 '24 18:08 AloeareV

So maybe we should put this behind the LRZ upgrade?

zancas avatar Aug 20 '24 06:08 zancas

Let's deprioritze this behind the LRZ update.

zancas avatar Sep 07 '24 01:09 zancas

Let's deprioritze this behind the LRZ update.

I don't know what you mean. The LRZ update is functional.

AloeareV avatar Sep 09 '24 18:09 AloeareV

Let's deprioritze this behind the LRZ update.

I don't know what you mean. The LRZ update is functional.

If this PR is not necessary to support ZIP320 in mobile, then let's delay work on it.

zancas avatar Sep 09 '24 18:09 zancas

closing in favor of: #1457

juanky201271 avatar Oct 16 '24 02:10 juanky201271