Michael Zingale
Michael Zingale
Should there be a separate projection module that all the low speed solvers can use?
there is a lot of redundancy in the `lm_combustion` solver -- it should subclass simulation_null like the others do
## Summary ## Additional background ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [x] add new capabilities to AMReX - [...
AMReX now has a `volwgtsum` function: https://github.com/AMReX-Codes/amrex/pull/2961 we should be able to use this in place of the Castro version in `sum_utils.cpp`
## PR summary ## PR motivation ## PR checklist - [ ] test suite needs to be run on this PR - [ ] this PR will change answers in...
## PR summary addresses #328 ## PR motivation ## PR checklist - [ ] test suite needs to be run on this PR - [ ] this PR will change...
this doesn't yet work for parallel (MPI) ## PR summary ## PR motivation ## PR checklist - [ ] test suite needs to be run on this PR - [...
### Describe the bug **context** When I include a notebook with SymPy output, sometimes the standard latex font is used and sometimes a larger, uglier font is used for the...
We need to test `test_nse` in the regression test suite, or via a github action
we now have 2 different solvers, so this attempts to explain their differences