Michael Zingale comments

Results 336 comments of


                                            Michael Zingale

still have issues with pressure in 1-d momentum fluxes

it looks like this was missed in #2468

make clang-tidy recognize .H as a header

indeed. It only works with clang-tidy >= 17 see: https://github.com/AMReX-Codes/amrex/pull/3832

VODE failure in Detonation with self-consistent NSE

is this still an issue?

[REVIEW]: A course on the implicit finite volume method for CFD using Python

https://bitbucket.org/cdegroot/cfdcourse/issues/1/missing-community-guidelines

[REVIEW]: A course on the implicit finite volume method for CFD using Python

https://bitbucket.org/cdegroot/cfdcourse/issues/2/markdown-links-dont-render-in-tip-boxes https://bitbucket.org/cdegroot/cfdcourse/issues/3/comments-on-descriptions-in-chapter-1

[REVIEW]: A course on the implicit finite volume method for CFD using Python

https://bitbucket.org/cdegroot/cfdcourse/issues/4/comments-on-descriptions-in-chapter-2

[REVIEW]: A course on the implicit finite volume method for CFD using Python

yes, I will look very soon. Finishing grading now. On Mon, May 10, 2021 at 1:32 PM Lorena A. Barba ***@***.***> wrote: > Hi @zingale 👋 — I see that...

[REVIEW]: A course on the implicit finite volume method for CFD using Python

I'm happy with the current state and I believe I've checked off everything. Thank you for looking at my issues and nice work overall!

remove the initial model code -- it lives on its own now

this implements #22

resolution of g-modes

can you do a PR with this problem and the script to produce the plot comparing to analytic?