Michael Zingale
Michael Zingale
this will be straightforward once #2869 is merged. Then there is just a bit more cleaning.
once #2897 is merged, I can move the relevent headers into `Castro/Source/hydro` and then hook this in as an option.
You can just squash on merge for the PR and it will look clean.
I'd bet the issue is that the VR doesn't handle AMR where the jumps vary by level.
still need to do: - [ ] documentation - [ ] test problem / notebook - [ ] isolated BCs via MG expansion
I think that this is the geometry you want: 
you should only need to add 3 functions to Grid2d: area_x() area_y() volume() it might also be good to add an assertion on the angle (y) the ghost cells should...
unfortunately, I don't have access to the readthedocs account for pyro -- someone else created it.
@IanHawke do you have access to the RTD page? Is it possible to disable the pyro docs? We've switch back to a github action since we have more control over...
along these lines, what about adding a likely attribute: https://en.cppreference.com/w/cpp/language/attributes/likely