lottie-rs
lottie-rs copied to clipboard
Update to bevy 0.13
I'm now trying to create PR to migrate to bevy 0.13.
https://github.com/funatsufumiya/lottie-rs/commit/633ab4e9446f084eae40bb4c8d30f1a654257713
However, shader validation error occurs while $ cargo r --release -- --input fixtures/ui/drink.json
. Any helps are welcome...
2024-04-10T22:09:16.018344Z ERROR log: Device::create_shader_module error:
Shader validation error:
┌─ :1:1
│
1 │
│
│
│ naga::Expression [6]
│ invalid function call
2024-04-10T22:09:16.023935Z ERROR bevy_render::render_resource::pipeline_cache: failed to create shader module: Validation Error
Caused by:
In Device::create_shader_module
Shader validation error:
┌─ :1:1
│
1 │
│
│
│ naga::Expression [6]
│ invalid function call
For this, I also upgraded bevy_tweening capture_fn branch to bevy 0.13. https://github.com/funatsufumiya/bevy_tweening/commit/eb37435c04f3dd226bd3784664f4f42b8d57bc7e
Confirmed mainly working well, but only one test is not passing:
test plugin::tests::change_detect_component ... FAILED
failures:
---- plugin::tests::change_detect_component stdout ----
thread 'plugin::tests::change_detect_component' panicked at src/plugin.rs:175:43:
Requested resource bevy_time::time::Time does not exist in the `World`.
Did you forget to add it using `app.insert_resource` / `app.init_resource`?
Resources are also implicitly added via `app.add_event`,
and can be added by plugins.
failures:
plugin::tests::change_detect_component
test result: FAILED. 45 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.38s
thanks for the report, I'll try to get some time to investigate this
by the way is it OK if I directly upgrade to bevy 0.13, or would your prefer to open a PR and contribute to this project?
Sorry, I didn't notice this!
by the way is it OK if I directly upgrade to bevy 0.13
Sure, thank you :)
@funatsufumiya please try this newly updated version, and possibly report any failed lottie file. Thanks.
Confirmed working :) I have some lottie json files not rendered properly, but these also not rendered well in rlottie.
I'll investigate them. Thanks!