Setting cluster status to active without passing --environment does not return error

[swarupdonepudi]

When I ran the command to set cluster status to active without passing the environment, the call returns a "Setting cluster status active" message but does not really set the cluster to active. But when I pass --environment dev I see the following output.

Setting cluster environment to dev
Setting cluster status active

Does not work(which is great): kubectl hyperkube set-cluster-status --status active --cluster <cluster-fqdn> Works: kubectl hyperkube set-cluster-status --status active --cluster <cluster-fqdn> --environment <cluster-env>

Not working version should display an error message to the user.

[swarupdonepudi]

I just noticed that running this command without passing --environment is inserting a record in dynamodb table which can be verified by running kubectl hyperkube list

[sepulworld]

We didn’t initially want to make these cluster meta data items mandatory, but perhaps we do now?

[swarupdonepudi]

I think it is a good idea to make environment a mandatory input with a sane default dev maybe?

[sepulworld]

Perhaps the default should be configurable. I was thinking maybe a dynamodb table meant for configuration defaults that can be used to override hard coded constants.