knowhere icon indicating copy to clipboard operation
knowhere copied to clipboard

Don't kill the thread with fixable issue

Open liliu-z opened this issue 6 months ago • 2 comments

From the code, this error will kill the folly thread, and exception will throw from WaitAllSuccess. Then the catch block outside will catch this error and return an error code to Milvus. User will get error report, do some modification and then retry. But the folly thread is permenentally dead.

  1. If this is an unexpected error, we need to crash the Milvus
  2. If it is a fixable problem (mis operation order, retryable), then we should not kill the thread.

Originally posted by @liliu-z in https://github.com/zilliztech/knowhere/pull/746#discussion_r1728625505

liliu-z avatar Aug 23 '24 09:08 liliu-z