knowhere icon indicating copy to clipboard operation
knowhere copied to clipboard

remove seed_ef and use ef for hnsw iterator

Open zhengbuqian opened this issue 1 year ago • 4 comments

kind/improvement

issue: https://github.com/zilliztech/knowhere/issues/500

zhengbuqian avatar May 24 '24 07:05 zhengbuqian

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 24 '24 07:05 sre-ci-robot

@zhengbuqian 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

mergify[bot] avatar May 24 '24 07:05 mergify[bot]

kind/improvement

issue: #500

zhengbuqian avatar May 24 '24 07:05 zhengbuqian

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.28%. Comparing base (3c46f4c) to head (f4078cf). Report is 71 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #599       +/-   ##
=========================================
+ Coverage      0   70.28%   +70.28%     
=========================================
  Files         0       67       +67     
  Lines         0     4718     +4718     
=========================================
+ Hits          0     3316     +3316     
- Misses        0     1402     +1402     

see 67 files with indirect coverage changes

codecov[bot] avatar May 24 '24 08:05 codecov[bot]

/lgtm

alwayslove2013 avatar May 27 '24 01:05 alwayslove2013

kind/improvement

issue: https://github.com/zilliztech/knowhere/issues/500

zhengbuqian avatar May 27 '24 02:05 zhengbuqian

/kind improvement

cydrain avatar May 27 '24 02:05 cydrain