knowhere icon indicating copy to clipboard operation
knowhere copied to clipboard

improve the iterator implementation

Open zhengbuqian opened this issue 2 years ago • 2 comments

so that we can avoid as much duplicate code between indexes as possible and form a good foundation for Cardinal to add iterator support

zhengbuqian avatar Apr 16 '24 06:04 zhengbuqian

TODOs after #501:

  • [ ] hnsw iterator use brute force for high filter rate
  • [ ] hnsw iterator to limit to_visit size by search 1 step every several Next() calls.
  • [ ] ivf iterator to copy and own query data
  • [ ] DiskANN iterator impl
  • [ ] IVF-SQ8 iterator impl: this is being targeted in https://github.com/zilliztech/knowhere/pull/414
  • [ ] HNSW impl has support for binary vector, but it is not officially supported. Thus hnsw iterator on binary vector is not properly tested: this is being targeted in https://github.com/zilliztech/knowhere/pull/494
  • [x] make the parameters configurable

zhengbuqian avatar Apr 16 '24 10:04 zhengbuqian

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

github-actions[bot] avatar May 20 '24 01:05 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

github-actions[bot] avatar Jun 27 '24 01:06 github-actions[bot]