knowhere icon indicating copy to clipboard operation
knowhere copied to clipboard

remove override range_search from ivf, use iterator-based instead

Open alwayslove2013 opened this issue 7 months ago • 1 comments

/kind improvement

alwayslove2013 avatar May 21 '25 10:05 alwayslove2013

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013 To complete the pull request process, please assign liliu-z after the PR has been reviewed. You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 21 '25 10:05 sre-ci-robot

@alwayslove2013 is it good to review these diffs? It seems that they fail UTs

alexanderguzhva avatar May 29 '25 19:05 alexanderguzhva

is it good to review these diffs? It seems that they fail UTs

alwayslove2013 avatar May 30 '25 01:05 alwayslove2013

@alexanderguzhva, it appears that there are some additional questions; I will address them first.

alwayslove2013 avatar May 30 '25 01:05 alwayslove2013