VectorDBBench icon indicating copy to clipboard operation
VectorDBBench copied to clipboard

"--refine-type" and "--refine-k" should be required only when "--refine" is set to True

Open cydrain opened this issue 2 months ago • 1 comments

When "--refine" is set to False, user is still required to set the params "--refine-type" and "--refine-k", it's unreasonable. "--refine-type" and "--refine-k" should be required only when "--refine" is set to True.

[root@host70 caiyd]# vectordbbench milvushnswsq   --uri "http://10.220.56.72:19530"   --case-type Performance1024D10M  --drop-old   --m 16   --ef-construction 256   --ef-search 100 --refine False
Usage: vectordbbench milvushnswsq [OPTIONS]
Try 'vectordbbench milvushnswsq --help' for help.

Error: Missing option '--refine-type'. Choose from:
        sq6,
        sq8,
        bf16,
        fp16,
        fp32

cydrain avatar Nov 08 '25 00:11 cydrain

good catch, I will open a pr to fix it~

alwayslove2013 avatar Nov 25 '25 10:11 alwayslove2013