core icon indicating copy to clipboard operation
core copied to clipboard

[Extensions] Do not translate MetaData

Open craigh opened this issue 4 years ago • 1 comments

In \Zikula\Bundle\CoreBundle\Composer\MetaData we attempt to translate several properties:

  • description
  • displayName
  • url

In addition, we also dynamically set these properties in the Extensions UI and then reset them when MetaData is constructed (currently here but PR moves to here)

This seems bad practice. we should not be doing both translation and dynamic replacement. I suggest removal of the translation.

Technically this would be a BC break. But in userland, I doubt very much that the translation is being used by anyone because the strings are not (can not?) be extracted. so they are likely not available as translations unless a user manually sets it up (which seems unlikely). Additionally this data is not user-facing, but rather admin viewable only, I believe. Therefore, I suggest for removal at 3.1.0.

@Guite ?

craigh avatar Aug 05 '20 14:08 craigh

Fine with dropping translation.

rather admin viewable only

One exception for that: the display name is (or at least was) often used as heading in the user area.

Premium solution would be an ability to enter these values for each language in UI. Could be postponed as a separate issue for 4.0

Guite avatar Aug 05 '20 16:08 Guite

Closing as won't fix as state-based extensions handling will be entirely removed in favor of Composer and Flex.

Guite avatar Aug 16 '22 18:08 Guite