monaco-editor-textmate
monaco-editor-textmate copied to clipboard
Update API for retrieving theme in monaco-editor version 0.21.2
The new API is: editor._themeService._theme instead of editor._themeService.getTheme()
Can you please document this breaking change in README? i.e inform people that the latest version of this package requires monaco-editor version <x.x.x> or up (the minimum version that brought this change) and if they wish to use it with version <x.x.x> or below they can use an older version 2.2.2 of this library.
Your contribution is truly appreciated.
Hey Neek, I'm not very familiar with working with PR's, but I'll assume I can just push another commit to this PR without creating a new one... going to give that a try. ...Looks like it worked
One question: should I also worry about incrementing any version numbers in the package.json? I'm not very familiar with NPM publishing either haha.
Please can this be merged... all the recent Monaco versions are not working. I can confirm that his fixes the issue 👍🏻
I'll merge this later today
My apologies for the slack folks, been quite busy at work this week.
I'm gonna need someone to resolve the conflicts though, it's been 4 years since I've used this library (or monaco) personally so don't know which changes I need to keep and which to discard.
I created new pull request that has latest version as base
Merged #23 instead