zigpy-zigate icon indicating copy to clipboard operation
zigpy-zigate copied to clipboard

zigpy-zigate 0.8.0 or newer 0.8.x release with later fixes already added?

Open Hedda opened this issue 3 years ago • 9 comments

@doudz Looks like you bumped zigpy-zigate version to 0.8.0 but missed tagging it for release so not available via PyPI/pip?

ZeGuigui wrote this here:

https://github.com/zigpy/zigpy-zigate/commit/69b02f1c58f5642b032a7fccb90504bfd463cd0d

Do you plan to add a tag so this release will be pushed to pypi.org or should I hard install it to test the reconnect feature?

https://github.com/zigpy/zigpy-zigate/releases

https://github.com/zigpy/zigpy-zigate/tags

https://pypi.org/project/zigpy-zigate/#history

https://pypi.org/project/zigpy-zigate/#files

If and when it is ready I assume will also update Home Assistant core via a PR?

https://github.com/home-assistant/core/pulls?q=zigpy-zigate

Hedda avatar Jun 08 '21 07:06 Hedda

Maybe also need to add/update workflows for release management?

Comparing

https://github.com/zigpy/zigpy/tree/dev/.github/workflows or https://github.com/zigpy/bellows/tree/dev/.github/workflows

verses

https://github.com/zigpy/zigpy-zigate/tree/dev/.github/workflows

Hedda avatar Jun 08 '21 07:06 Hedda

the release is not ready that's why I didn't tag it

doudz avatar Jun 09 '21 18:06 doudz

the release is not ready that's why I didn't tag it

OK. Just assumed based on https://github.com/zigpy/zigpy-zigate/commit/69b02f1c58f5642b032a7fccb90504bfd463cd0d bump as usually major and minor version bumps are done last just before release

Hedda avatar Jun 10 '21 06:06 Hedda

@doudz Any chance you could test and bump the release version 0.8.1

Home Assistant core looks to still be using zigpy-zigate 0.7.3 release:

https://github.com/home-assistant/core/blob/dev/homeassistant/components/zha/manifest.json

https://github.com/home-assistant/core/pulls?q=zigpy-zigate

That does not contain the later fixes that you added after that.

See comment by @Xavier-M in https://github.com/zigpy/zigpy-zigate/issues/101 so maybe he is willing to test it.

Hedda avatar Nov 16 '21 14:11 Hedda

Sorry, no time to work on zigate 😞

doudz avatar Nov 17 '21 20:11 doudz

Hi @doudz, do you think you could release the 0.8.0? We could take care of the testing in home assistant, and do the PR to integrate it in ZHA if needed.

MichaelBitard avatar Jan 22 '22 12:01 MichaelBitard

@MichaelBitard Check out the somewhat related discussion in https://github.com/zigpy/zigpy-zigate/issues/104 about help with test mentioned fork with Home Assistant.

Help if needed regression testing mentioned zigpy-zigate fork as if it does not break anything PRs can be submitted upstream.

That is, those working on that fork can/will not test ZHA themselves but they can submit PRs here if someone else can test it.

Hedda avatar Jan 25 '22 13:01 Hedda

That would be very much appreciated when 0.8.0 is released so at least.whe can test it. I am not relying on the Zigate wifi. So testing would be nice.

Gemies avatar Feb 04 '22 15:02 Gemies

FYI, please read discussions in https://github.com/zigpy/zigpy-zigate/issues/116 and https://github.com/zigpy/zigpy/discussions/880 about zigpy-zigate first needing additional maintainer(s) to volunteer.

Hedda avatar Feb 06 '22 09:02 Hedda