zha-device-handlers
zha-device-handlers copied to clipboard
Added support for TS0049 Tuya Water Valve
For more details refer to this issue: https://github.com/zigpy/zha-device-handlers/issues/2377
Proposed change
Added suport for TS0049 Water Valve from Tuya.
Additional information
This handler was proposed by the users of the issue 2377 and after a few months around, we believe it is quite stable to be included in the final list.
Checklist
- [X] The changes are tested and work correctly
- [X]
pre-commitchecks pass / the code has been formatted using Black - [ ] Tests have been added to verify that the new code works
Codecov Report
Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.
Project coverage is 88.66%. Comparing base (
10a17d3) to head (2413e14). Report is 175 commits behind head on dev.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| zhaquirks/tuya/ts0049.py | 81.48% | 5 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## dev #2624 +/- ##
==========================================
+ Coverage 86.59% 88.66% +2.07%
==========================================
Files 277 305 +28
Lines 8531 12451 +3920
==========================================
+ Hits 7387 11040 +3653
- Misses 1144 1411 +267
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.
This needs a few changes (especially test coverage), but I still want to take a look.