zigpy
Remove Yooksmart quirk
There is actually no issue with the percentage reported on the Yooksmart shades.
Fix #1306
Codecov Report
Patch and project coverage have no change.
Comparison is base (
6e5e538) 83.85% compared to head (6d135b1) 83.86%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@
## dev #1664 +/- ##
=======================================
Coverage 83.85% 83.86%
=======================================
Files 259 258 -1
Lines 8203 8188 -15
=======================================
- Hits 6879 6867 -12
+ Misses 1324 1321 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Pull Request Test Coverage Report for Build 4390654035
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.007%) to 83.867%
| Totals | |
|---|---|
| Change from base Build 4379436109: | 0.007% |
| Covered Lines: | 6867 |
| Relevant Lines: | 8188 |
💛 - Coveralls
Are there firmware revisions still affected by this? I think instead of removing the quirk, we can just add a way to stop applying it depending on the device's current firmware version.
@puddly that makes sense to me. Can you link me to something that explains how to exclude firmware versions?
I have firmware versions 0x11013001 and 0x11206780 in use and they both don't need the quirk.
Happy to change this PR to only exclude those versions.
DO NOT approve this PR. Please see comment here https://github.com/zigpy/zha-device-handlers/issues/1306#issuecomment-1372402947
I was playing with this and reset my blind that was reporting normally... now it is reporting reversed. So all mine are now reversed... I think there is a bug in their firmware that sometimes fails to set the direction and thus reverses the blind. Resetting it and setting up again fixes it. I didn't even reset it's zigbee configuration just the up/down/direction part. I agree removing the quirk and then instructing people if they run into this to reset the blind and run through setting limits and direction again.
Rebased. IMO, we should merge this, as the initial PR was already full of complaints:
- https://github.com/zigpy/zha-device-handlers/pull/971
And the issue also complains about the quirk inverting the blinds:
- https://github.com/zigpy/zha-device-handlers/issues/1306
rwalker777 previously mentioned that the PR shouldn't be merged, but now says the quirk should be removed, as the pairing seemingly didn't complete successfully the first time.
Also see this comment about how there's no actual issue: https://github.com/zigpy/zha-device-handlers/issues/1306#issuecomment-1372523432
Z2M also seems to have removed their "inverted" option for this (regardless of firmware): https://github.com/Koenkk/zigbee-herdsman-converters/commit/a25ef0708ed9bd64609f646b1425aa211698fc7d (See their issue: https://github.com/Koenkk/zigbee2mqtt/issues/14361)
Ideally, the blinds can be re-paired and then work properly. Everyone who's currently modifying zha-quirks directly (to remove the quirk) and those who are using a custom quirk to override the built-in one can stop modifying their stuff.
In the unlikely case that some people need the inverted reporting (which would have been "long" noticed with Z2M IMO), the quirk can temporarily be installed back as a custom quirk: https://github.com/zigpy/zha-device-handlers/blob/6e5e5384c5a0a2788458c2e1a20e105e24398e72/zhaquirks/yooksmart/D10110blinds.py
Read up more on the issue and it seems like there were only complaints in the Z2M repo when the cover was (wrongfully) inverted.
The fix will likely land with HA Core 2023.4.0. So you can remove any custom quirks that override the built-in one then or stop modifying your HA installation when upgraded. I'll monitor the issues closely at that time, but don't expect any.