zha-device-handlers
zha-device-handlers copied to clipboard
zigpy
add ts0601 _TZE200_znzs7yaw
from work done here https://github.com/zigpy/zha-device-handlers/issues/1015
Pull Request Test Coverage Report for Build 2479395953
- 50 of 91 (54.95%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.3%) to 80.011%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| zhaquirks/tuya/ts0601_haozee.py | 50 | 91 | 54.95% |
| <!-- | Total: | 50 | 91 |
| Totals | |
|---|---|
| Change from base Build 2461934928: | -0.3% |
| Covered Lines: | 5656 |
| Relevant Lines: | 7069 |
💛 - Coveralls
If its working OK for the user its OK then the original one was not well teased but i think this user have doing it.
Only one PM of the naming if the quirk can being better or implanted in the ts0601_electric_heating.py then in the end its one tuya device and they is coming in many colors and brands (and strange functions) ;-))
I updating the tuya TRV matrix with that is being one PR made and waiting merging.
I updating the tuya TRV matrix with that is being one PR made and waiting merging.
do you mean this PR or another? if it's another, can you link it pls.
All the TRV quirk is a little strange to me, so I can't tell much about the PR.
But I agree @MattWestb that the quirk name is not the best one. I think that we don't want to get full of ts0601_<manufacturerN>.py files.
David: https://github.com/zigpy/zigpy/discussions/653#discussioncomment-314395
I’m going to merge this. We can move it later if that’s what we want to do