zha-device-handlers icon indicating copy to clipboard operation
zha-device-handlers copied to clipboard

Update ts0601_electric_heating.py

Open SentrySOB opened this issue 2 years ago • 13 comments

Fix TZE200_2ekuz3dz divider report correct temp

SentrySOB avatar Jun 06 '22 08:06 SentrySOB

Pull Request Test Coverage Report for Build 2495591762

  • 17 of 74 (22.97%) changed or added relevant lines in 1 file are covered.
  • 80 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 79.733%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zhaquirks/tuya/ts0601_electric_heating.py 17 74 22.97%
<!-- Total: 17 74
Files with Coverage Reduction New Missed Lines %
zhaquirks/tuya/init.py 80 72.23%
<!-- Total: 80
Totals Coverage Status
Change from base Build 2440122483: -0.5%
Covered Lines: 5622
Relevant Lines: 7051

💛 - Coveralls

coveralls avatar Jun 06 '22 09:06 coveralls

Codecov Report

Merging #1609 (13c698c) into dev (b655616) will decrease coverage by 0.42%. The diff coverage is 25.92%.

@@            Coverage Diff             @@
##              dev    #1609      +/-   ##
==========================================
- Coverage   80.23%   79.80%   -0.43%     
==========================================
  Files         231      231              
  Lines        6940     6993      +53     
==========================================
+ Hits         5568     5581      +13     
- Misses       1372     1412      +40     
Impacted Files Coverage Δ
zhaquirks/tuya/ts0601_electric_heating.py 42.85% <25.92%> (-14.72%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b655616...13c698c. Read the comment docs.

codecov-commenter avatar Jun 06 '22 10:06 codecov-commenter

Added Beok TGR85_ZB Manufacturing cluster. Temp is working. HVAC function needs fixing still.

SentrySOB avatar Jun 06 '22 13:06 SentrySOB

Looks like tuya have making changes in newer devices and using the new standard of multiples for some thermostat MCU like they have done with new TRVs. https://github.com/Koenkk/zigbee2mqtt/issues/11980

If you need presets for working mode you can looking how its done for the tuya TRV but they they is always on and cant being turned off so they is using presets in ZHA climate component.

Great work done !!!

MattWestb avatar Jun 06 '22 19:06 MattWestb

MoesBHT have a diferent signature than BeokTGR85_ZB (+ GreenPowerProxy). This will be a breaking change for any _TZE200_2ekuz3dz device with the MoesBHT signature. Keep the model in both classes. If the signature is diferent there is no problem to duplicate.

javicalle avatar Jun 06 '22 20:06 javicalle

I added _TZE200_2ekuz3dz and it has never worked with the MoesBHT signature. It still doesn't have HVAC action. The GPP change enabled it to show the temp. Apparently if use LOCALTUYA to connect it works fine. I don't have a TUYA Zigbee hub to test that. Was from there I found the information that it is actually a Beok TGR85_ZB.

https://community.hubitat.com/t/looking-or-help-with-beok-tuya-zigbee-smart-thermostat-heating-thermostat/87044

SentrySOB avatar Jun 07 '22 00:06 SentrySOB

It is now showing Thermostat hvac_action. The entity is blue, yet the state is Unknown.

SentrySOB avatar Jun 07 '22 00:06 SentrySOB

Can please someone explain to me what i have to do to get things working? you can see the degrees 145, missing comma

image

itsolon avatar Jun 14 '22 10:06 itsolon

I just added the ("_TZE200_2ekuz3dz", "TS0601"), back to the MoesBHT signature. Hopefully that will correct the 145C to 14.5C

SentrySOB avatar Jun 14 '22 13:06 SentrySOB

i updated the file to the big one with 419 lines it still has the 145..

image

image

itsolon avatar Jun 14 '22 19:06 itsolon

Have you downloaded the latest patch and copied it to your custom ZHA quirk?

Your device signature is still showing up as MoesBHT_GPP. It should be reading BoekTGR85.

I have the temp reading correctly on mine yet the thermostat still isn't working properly as ZHA can't talk to the new TUYA format or something.

I'm probably giving up on ZHA and moving back to Zigbee2MQTT. There is almost no documentation and very little assistance for ZHA so going back to MQTT where the converter integration is much better and for me is much easier to program. Discord is no help. People just question why I haven't done things and seem to expect everyone to know every detail. Meanwhile, after several hours of looking for information, the advice they give turns out to be wrong. They just say it in a way that they assume they are correct, yet give no actual help, and turns out what they are assuming doesn't work anyway.

Not really sure what the point of ZHA is or why it has been added. Seems Home Assistant want to make their own interface, yet also seems they are just relying on the community to do it for them. Which makes no sense as the community were already building Zigbee2MQTT and most seem to still be there.

Unless Nabu Casa want to get involved and put some effort into ZHA seems to me they might as well just delete it now so as not to waste the communities time trying to develop 2 systems to do the same job.

Good luck with getting things to work. I am done though with ZHA.

SentrySOB avatar Jun 15 '22 00:06 SentrySOB

Many thanks for sharing your experience and getting me to think over my roadmap with or without zha. the reason why i prefered it over zigbee to mqtt is: i use 2 systems of home assistant (home, and office) and for sync reasons i use software which can sync both systems (some integraion i do not know the name at the moment) and by using mqtt the devices i have in mqtt are synced double, that was the reason why i tried to avoid mqtt ,,, but as far as i can see now, koenk with zigbee2mqtt hat far better hardware support, everytime i buy new device it is not supported with zha.. and when i do recherche on internet i see .. support with zigbee2mqtt already available. i think i will follow your thoughts and throw out zha on my studio (fewer devices) and collect experience with that system.

itsolon avatar Jun 15 '22 07:06 itsolon

i moved to zigbee2mqtt, but i can say that there it is also not supported, and the support community seems to be at first sight not so good like here at zha.. perhaps i come back if device not supported until winter best wishes and thank you for everything.

itsolon avatar Jun 26 '22 17:06 itsolon

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Dec 23 '22 17:12 github-actions[bot]