Sergi Meseguer
Sergi Meseguer
no man, thank you both, again
I don't really know about the details, and as such I might be wrong, but I'd swear the suspect is https://github.com/garris/BackstopJS/blob/f9070c5c388bb3c173ea1370cce7bfa33215de84/core/util/compare/compare-hash.js#L23
Sorry @brendonbarreto I cannot run your script, npm dependencies system is a complete mess (not your fault) :) If I install it in package.json, it would run the global backstopjs....
No because somehow it breaks my `yarn dev` (smth webpack related). I will isolate this in a barebones folder, will keep you posted
Sorry @brendonbarreto a bit embarrassed but there's no way I can run the local backstopjs, only the 3.7.0, any step-by-step help would be appreciated.
OK got it! took me longer than expected, sorry. @brendonbarreto Same problem with your branch, diff% 0.04, misMatchThreshold: 0.01, and test passes. I used the no-tick image as reference, then...
hi @brendonbarreto sorry for the delay. you mean you cannot reproduce the "false pass" using my images from https://github.com/garris/BackstopJS/issues/850#issuecomment-433117854 ? Not in your branch and not even in master? Weird,...
For the record, still pretty sure the problem is the threshold evaluation. Been doing quite a lot of small changes, all using `misMatchThreshold: 0.01`, and I'm consistently getting wrong PASSED...
OK I found the problem @brendonbarreto Not sure how it might happened though. Whatever I set for `misMatchThreshold` as seen above is neglected, it still uses the default `misMatchThreshold: 0.1`....
BINGO, sorry all the noise, I was setting the `misMatchThreshold` on two places, the only valid being inside the scenario. Please excuse my stupidity...