zig icon indicating copy to clipboard operation
zig copied to clipboard

Compilation: add missing link file options to cache manifest

Open mlugg opened this issue 11 months ago • 1 comments

I unintentionally closed #23891 while pruning branches; this is the exact same diff.

Resolves: #23869

mlugg avatar May 18 '25 20:05 mlugg

I'll take that, I certainly don't think it can cause any issues. I'll try and double check that it actually fixes the issue (I barely tested this locally lol) and merge if all is well.

mlugg avatar May 29 '25 15:05 mlugg

Rebased, and tested the -fentry case locally -- and at that point I had pretty much written a standalone test case anyway, so I added that in. The test is confirmed as failing on master and passing on this PR.

mlugg avatar Jun 16 '25 11:06 mlugg

-fentry is either broken on our Mach-O linker or requires something special, so I've just hardcoded the standalone test target to x86_64-linux, since I know it works there. That's fine, since we're mainly trying to test the frontend there, and in particular the caching mechanism.

mlugg avatar Jun 17 '25 09:06 mlugg