zig icon indicating copy to clipboard operation
zig copied to clipboard

std.Build: Implement addEmbedPath for adding C #embed search directories

Open GalaxyShard opened this issue 1 year ago • 3 comments

Closes #21626

Allows adding new search directories to C23's #embed

GalaxyShard avatar Oct 09 '24 05:10 GalaxyShard

do u know where the docs are specifying --embed-dir is the right flag to use? can you add a test?

nektro avatar Oct 09 '24 05:10 nektro

do u know where the docs are specifying --embed-dir is the right flag to use?

It was linked in the original issue, but here it is: https://clang.llvm.org/docs/ClangCommandLineReference.html

--embed-dir=<dir>

Add directory to embed search path


can you add a test?

Sure

GalaxyShard avatar Oct 09 '24 06:10 GalaxyShard

@nektro I added a test, would you mind checking if I created it in the correct place and all?

GalaxyShard avatar Oct 09 '24 22:10 GalaxyShard

If someone could run CI that would be great.

GalaxyShard avatar Oct 28 '24 08:10 GalaxyShard

Test failure should be fixed now; it was expecting \n for a newline (causing failure on windows with \r\n).

GalaxyShard avatar Oct 30 '24 03:10 GalaxyShard

Is there anything that should be done before this gets merged? Thanks.

GalaxyShard avatar Mar 01 '25 20:03 GalaxyShard

Looks like this needs an update for current master.

alexrp avatar Mar 26 '25 17:03 alexrp

Should be fixed now.

GalaxyShard avatar Mar 26 '25 20:03 GalaxyShard