zig icon indicating copy to clipboard operation
zig copied to clipboard

[expectApproxEqAbs] Adding Vector support

Open dmurph opened this issue 1 year ago • 1 comments

This change adds vector support to the expectApproxEqAbs method, allowing vectors to be passed there.

I couldn't figure out how to test this, sadly (you can see my struggles on Issue #20658).

I'm not sure what will happen if there are two different lengths of the same type - I'm not sure what @typeof would do for that.

dmurph avatar Jul 17 '24 03:07 dmurph

I'm not sure what will happen if there are two different lengths of the same type - I'm not sure what @typeof would do for that.

@TypeOf() would compile-error when trying to coerce vectors of differing lengths.

If you're adding support for expectApproxEqAbs, could you add it to expectApproxEqRel at the same time?

Rexicon226 avatar Jul 17 '24 04:07 Rexicon226