zig icon indicating copy to clipboard operation
zig copied to clipboard

fix(cache): handle missing cache hits when chaining two run steps

Open bfredl opened this issue 1 year ago • 0 comments

fixes #19817

This improves the efficiency of the cache when chaining muliple commands like

const step1 = b.addRunArtifact(tool_fast);
step1.addFileArg(b.path("src/input.c"));
const output1 = step1.addOutputFileArg("output1.h");

const step2 = b.addRunArtifact(tool_slow);
step2.addFileArg(output1);
const chained_output = step2.addOutputFileArg("output2.h");

assume that step2 takes much long time than step1 if we make a change to "src/input.c" which produces an identical "output1.h" as a previous input, one would expect step2 not to rerun as the cached output2.h only depends on the content of output1.h

However, this does not work yet as the hash of src/input.c leaks into the file name of the cached output1.h, which the second run step interprets as a different cache key. Erasing the "zig-build/o/{HASH}" part of the file name in the hash key fixes this.

bfredl avatar May 15 '24 09:05 bfredl