zig
zig copied to clipboard
Add realtime scheduling calls to std.os.linux (issue #19671)
Add the following system calls to std.os.linux:
- sched_setscheduler
- sched_getscheduler
- sched_setparam
- sched_getparam
- sched_get_priority_min
- sched_get_priority_max
Also add required sched_param structure and SCHED constant definitions:
- pub const sched_param
- pub const SCHED
Looks good with a few minor adjustments.
If you feel like it, it would be nice to also have these:
sched_getcpusched_getattr/sched_setattrsched_rr_get_interval
But that's not required to merge this, so if you don't feel like it, that's totally fine. :slightly_smiling_face:
@curuvar do you think you'll be able to address my review comments soon? If you don't have time, that's totally fine; I can make the adjustments in that case.
I’ll make the changes.
On 12 Nov 24, at 16:16, Alex Rønne Petersen @.***> wrote:
@curuvar https://github.com/curuvar do you think you'll be able to address my review comments soon? If you don't have time, that's totally fine; I can make the adjustments in that case.
— Reply to this email directly, view it on GitHub https://github.com/ziglang/zig/pull/19675#issuecomment-2471599817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOAJTISOP6SW53SI2ZWORHD2AJV2BAVCNFSM6AAAAABGLQDXRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZRGU4TSOBRG4. You are receiving this because you were mentioned.
I made the requested changes and added:
sched_getcpu sched_getattr sched_setattr sched_rr_get_interval
and "getcpu" as it was needed for sched_getcpu.
Nice, thanks! Just a couple of naming nitpicks and I think this one is good to go.