zig icon indicating copy to clipboard operation
zig copied to clipboard

Published 20 hours ago • verified publisher icon ziglang

Sema: fix OOB access in coerceTupleToStruct

Open wrongnull opened this issue 1 year ago • 6 comments

Closes https://github.com/ziglang/zig/issues/19529

wrongnull avatar Apr 11 '24 19:04 wrongnull

not sure if I should add test for this

wrongnull avatar Apr 11 '24 20:04 wrongnull

Probably should add a test yes :)

Rexicon226 avatar Apr 11 '24 21:04 Rexicon226

Screenshot_20240603_214413

wrongnull avatar Jun 03 '24 18:06 wrongnull

Please use Type.structFieldName and also update the equivalent code in coerceTupleToTuple to use it.

I promise I'll merge this as soon as it passes the CI.

Done. However I'm not sure if pr won't reverted because of this https://github.com/ziglang/zig/pull/18071#issuecomment-1850740167

wrongnull avatar Jul 15 '24 18:07 wrongnull

Done. However I'm not sure if pr won't reverted because of this #18071 (comment)

Right, guess I'll leave it then.

Vexu avatar Jul 15 '24 18:07 Vexu

I'll be waiting. No matter how long it takes

wrongnull avatar Jul 15 '24 18:07 wrongnull