zig icon indicating copy to clipboard operation
zig copied to clipboard

skip `standalone/empty_env` test in ConEmu terminal sessions

Open Parzival-3141 opened this issue 1 year ago • 4 comments

Closes #3168

The problem seems to be ConEmu setting environment variables before executing the test process (the test passes when run in Windows CMD). These variables can differ depending on user configuration too. This PR skips the test if the host environment has the ConEmuHWND variable set; i.e. we're running inside a ConEmu terminal session.

Parzival-3141 avatar Feb 17 '24 07:02 Parzival-3141

x86_64-linux CI failure seems unrelated?

Parzival-3141 avatar Feb 22 '24 20:02 Parzival-3141

yeah doesn't seem like it'd be your fault at first glance but its UB in the compiler causing a crash https://zigbin.io/544ee8

nektro avatar Feb 22 '24 20:02 nektro

@nektro Just to clarify, are you saying this is a separate bug or caused by the test?

Parzival-3141 avatar Feb 28 '24 05:02 Parzival-3141

I'm not totally sure, was more just documenting the finding to ease anyone else looking into it as well

nektro avatar Feb 28 '24 06:02 nektro

@alexrp please, no rebase commits if it is greater than 1 commit. This should have been a squash. The reasoning behind this is to ensure the ability to use git bisect. When there is greater than one commit in a rebase merge, it means there are direct children in master branch which have not passed the CI.

andrewrk avatar Oct 09 '24 01:10 andrewrk

@andrewrk sorry, I did intend for this to be a squash (per your earlier comment), which is why I disabled and re-enabled auto-merge. But apparently I accidentally selected the wrong option? 🤦 I'll keep a closer eye on that from now on.

alexrp avatar Oct 09 '24 06:10 alexrp

Thanks, appreciated!

andrewrk avatar Oct 09 '24 06:10 andrewrk