libc: fix cpu_mask

[wycers]

trafficstars

It should fix #15972

[matu3ba]

Please add (ideally minimal) unit tests for your fixes, so you do not need the word should.

[wycers]

@matu3ba You are right. After adding more tests, I did find some other bugs around it. BTW, could you tell me why the approval is still awaiting. Did I miss anything?

[matu3ba]

BTW, could you tell me why the approval is still awaiting. Did I miss anything?

First time contributors must have their CI runs on PRs approved.

[wycers]

@matu3ba I have fixed the mistake in test, could you help me trigger the CI again?

[matu3ba]

Hey @Wycers, I hope you are doing fine. Were you able to reproduce and could you fix the remaining bug(s)? Stale PRs will otherwise get closed (usually after 2 weeks).

run test std-powerpc-linux-none-Debug: error: 'test.cpu_set_t' failed: expected 255, found 15
/home/ci/actions-runner7/_work/zig/zig/lib/std/testing.zig:78:17: 0x103fd5c3 in expectEqual__anon_11639 (test)
                return error.TestExpectedEqual;
                ^
/home/ci/actions-runner7/_work/zig/zig/lib/std/os/linux/test.zig:151:9: 0x10da9417 in test.cpu_set_t (test)
        try expectEqual(@as(usize, 0xFF), set[i]);
        ^
run test std-powerpc-linux-none-Debug: error: while executing test 'decltest.buildFseTable', the following test command failed:
qemu-ppc /home/ci/actions-runner7/_work/zig/zig/build-debug/zig-local-cache/o/776907ba5a1a9b199e873794ab861ece/test --listen=- 
run test std-arm-linux-none-Debug: error: 'test.cpu_set_t' failed: expected 255, found 15
/home/ci/actions-runner7/_work/zig/zig/lib/std/testing.zig:78:17: 0x57336b in expectEqual__anon_11765 (test)
                return error.TestExpectedEqual;
                ^
/home/ci/actions-runner7/_work/zig/zig/lib/std/os/linux/test.zig:151:9: 0xe38bab in test.cpu_set_t (test)
        try expectEqual(@as(usize, 0xFF), set[i]);
        ^
run test std-arm-linux-none-Debug: error: while executing test 'decltest.buildFseTable', the following test command failed:
qemu-arm /home/ci/actions-runner7/_work/zig/zig/build-debug/zig-local-cache/o/d0a8c54d03c38e62af04fbf546055959/test --listen=- 
run test std-x86-linux-none-Debug: error: 'test.cpu_set_t' failed: expected 255, found 15
/home/ci/actions-runner7/_work/zig/zig/lib/std/testing.zig:78:17: 0x93afb4 in expectEqual__anon_11714 (test)
                return error.TestExpectedEqual;
                ^
/home/ci/actions-runner7/_work/zig/zig/lib/std/os/linux/test.zig:151:9: 0x11f8612 in test.cpu_set_t (test)
        try expectEqual(@as(usize, 0xFF), set[i]);
        ^
run test std-x86-linux-none-Debug: error: while executing test 'decltest.buildFseTable', the following test command failed:
/home/ci/actions-runner7/_work/zig/zig/build-debug/zig-local-cache/o/4ecacc034dc698a9bd8d1a592bb74784/test --listen=- 
run test std-mipsel-linux-none-Debug: error: 'test.cpu_set_t' failed: expected 255, found 15
/home/ci/actions-runner7/_work/zig/zig/lib/std/testing.zig:78:17: 0x57005b in expectEqual__anon_11619 (test)
                return error.TestExpectedEqual;
                ^
/home/ci/actions-runner7/_work/zig/zig/lib/std/os/linux/test.zig:151:9: 0x10bbb93 in test.cpu_set_t (test)
        try expectEqual(@as(usize, 0xFF), set[i]);
        ^
run test std-mipsel-linux-none-Debug: error: while executing test 'decltest.buildFseTable', the following test command failed:
qemu-mipsel /home/ci/actions-runner7/_work/zig/zig/build-debug/zig-local-cache/o/ac70dbb990ef45608d41ec682cfd809d/test --listen=- 
run test std-mips-linux-none-Debug: error: 'test.cpu_set_t' failed: expected 255, found 15
/home/ci/actions-runner7/_work/zig/zig/lib/std/testing.zig:78:17: 0x48aa53 in expectEqual__anon_11619 (test)
                return error.TestExpectedEqual;
                ^
/home/ci/actions-runner7/_work/zig/zig/lib/std/os/linux/test.zig:151:9: 0xfd8da7 in test.cpu_set_t (test)
        try expectEqual(@as(usize, 0xFF), set[i]);
        ^
run test std-mips-linux-none-Debug: error: while executing test 'decltest.buildFseTable', the following test command failed:
qemu-mips /home/ci/actions-runner7/_work/zig/zig/build-debug/zig-local-cache/o/f400262ad04815ad0b3787801df08027/test --listen=- 
Build Summary: 4329/4477 steps succeeded; 141 skipped; 5 failed; 146257/152995 tests passed; 6733 skipped; 5 failed (disable with -fno-summary)
test transitive failure

[wycers]

Hello @matu3ba，sorry for the delay，I will handle this promptly.

[wycers]

@matu3ba The tests passed in my local env, but I am still afraid that the CI testing may fail (as the previous few times). I guess I need some help here..if the CI failed again.

[andrewrk]

@Wycers thank you for working on this. Please note that @matu3ba is not a zig team member but rather an enthusiastic community member, and you can safely ignore his comments.

For your first contribution, I would please request that you stick to the bug fix, and then make the enhancements in a follow-up PR.

The conflicts with master branch are occurring due to a messy commit history. Tracking issue remains open. Please open a new PR to continue this work.