zig icon indicating copy to clipboard operation
zig copied to clipboard

all: rename i386 to x86

Open alichraghi opened this issue 3 years ago • 6 comments

Closes #4663 not sure what's wrong with Drone CI. that may be a cache issue

alichraghi avatar Oct 07 '22 17:10 alichraghi

The CI failure should be fixed by running tools/update_glibc.zig.

Vexu avatar Nov 03 '22 15:11 Vexu

running zig run tools/update_glibc.zig -- lib/libc/glibc/ . didn't change anything

alichraghi avatar Nov 03 '22 17:11 alichraghi

//! This script updates the .c, .h, .s, and .S files that make up the start
//! files such as crt1.o. Not to be confused with
//! https://github.com/ziglang/glibc-abi-tool/ which updates the `abilists`
//! file.

My bad.

Vexu avatar Nov 03 '22 18:11 Vexu

still failing but i think it's easy to fix. will try tomorrow EDIT: sorry didn't read this section

Not to be confused with https://github.com/ziglang/glibc-abi-tool/ which updates the `abilists` file.

alichraghi avatar Nov 03 '22 19:11 alichraghi

hmm new error is so weird. addIncludePath("test") is there and zig(2|3) translate-c test/behavior/translate_c_macros.h successed

alichraghi avatar Nov 04 '22 07:11 alichraghi

hmm new error is so weird. addIncludePath("test") is there and zig(2|3) translate-c test/behavior/translate_c_macros.h successed

The issue was that it was looking for the wrong include directory which can be fixed by renaming it, but doing so makes me question the correctness of the abilist change.

Vexu avatar Nov 04 '22 14:11 Vexu

CI is green! let's merge this faster because it get conflicts everyday

alichraghi avatar Nov 05 '22 03:11 alichraghi