zig icon indicating copy to clipboard operation
zig copied to clipboard

Published 20 hours ago • verified publisher icon ziglang

Correctly handle carriage return characters according to the spec

Open moosichu opened this issue 2 years ago • 3 comments

Taking guidance from: ziglang/zig-spec#38, carriage returns are now allowed preceding line-feeds when found in doc-comments or multiline strings. The CRLF is also only interpreted as a newline in this case. However - they are otherwise rejected when found in any other context except when used as plain whitespace.

This resolves #11414.

moosichu avatar Aug 28 '22 10:08 moosichu

I've added a couple of tests that should hopefully do the trick, one to check the case that should work and the other to test the case that should error.

moosichu avatar Sep 05 '22 07:09 moosichu

CI checks are failing

andrewrk avatar Oct 15 '22 14:10 andrewrk

Yeah - I haven't had the time to address those test issues for the the past while, but should hopefully be able to at the end of this week if that's ok :) Sorry for the delay on this one!

moosichu avatar Oct 22 '22 08:10 moosichu

Things should be fixed now! Ended up being something really simple, but only just had the time to get to it now.

moosichu avatar Oct 27 '22 14:10 moosichu

Are there any further changes desired here? Just double checking as I might have some time available to act on feedback this month if needed.

moosichu avatar Dec 05 '22 08:12 moosichu

Just resolved the merge conflicts that I saw had cropped-up (hopefully :crossed_fingers:)

moosichu avatar Dec 11 '22 19:12 moosichu