zig icon indicating copy to clipboard operation
zig copied to clipboard

Published 20 hours ago • verified publisher icon ziglang

std.debug: handle some possible errors and resolve low-hanging TODOs

Open wooster0 opened this issue 1 year ago • 3 comments

ttyconf.setColor(stderr, .Dim) just like stderr.print("{s}", .{plain.msg}) can fail, so I don't see why we wouldn't handle the former just like the latter. It's an edge case. You can always still ignore the error in your specific case if you want to. Apart from that it solves a bunch of related TODOs and it also removes a bunch of unreachables in std.Progress which is supposed to be non-fallible because now I'm confident these unreachables can be reached since the user can modify the std.Progress.terminal field. It can probably fail anyway. Better safe than sorry.

wooster0 avatar Jul 30 '22 12:07 wooster0

Looks like I merged your PRs out of order. Sorry about that. You mind rebasing this one?

andrewrk avatar Oct 15 '22 18:10 andrewrk

Sure! Rebased.

wooster0 avatar Oct 16 '22 09:10 wooster0

Now it should be up-to-date again.

wooster0 avatar Oct 28 '22 19:10 wooster0

aarch64-windows got stuck so I rebased once more. All other CIs already passed though.

wooster0 avatar Dec 13 '22 08:12 wooster0