Band names strip '

[dgw]

I find that Bucket often learns band names that originally contained ', like contractions (it's, that's, you're, etc.). They make no sense, and look bad, unless I or another admin manually delete the band name and re-add it with the apostrophe.

Somewhere in Bucket's code, it'd be great to disable stripping that out for band names.

[dgw]

Finally had a little motivation to go hunting for this. Looks like sub add_new_band uses $bag->{stripped_name} for some reason. I don't really understand the logic of sub check_band_name yet, though, so it might mean reworking the whole system to allow apostrophes and still avoid duplicates.

[dgw]

And another small round of looking into this (bored and sick, no huge amount of work) showed me that removal of ' from band names has been around since before Bucket was on GitHub. Git blame indicates the line removing apostrophes has been around since 94d1007, the first GH commit.

@zigdon Do you remember if there was a reason for doing that? Especially since e.g. "won't" and "wont" are different words.

Edit: Self-assigned so I don't forget about this issue for another two years.

[zigdon]

No reason I remember. And I don't think there's a reason why check_band_names should change, it already leaves ' in the words it checks for.