GitToolBox icon indicating copy to clipboard operation
GitToolBox copied to clipboard

git blame gitmoji not showing

Open itspooya opened this issue 4 years ago • 8 comments

When showing git blame in IDE the gitmoji doesn't get rendered and shows as a text

itspooya avatar Mar 16 '20 06:03 itspooya

Hi, I only provide completion in commit dialog.

Places where I could add display would be ones from my plugin:

  • [ ] status bar blame tooltip
  • [ ] blame details popup

Maybe places:

  • [ ] inline blame

For Git Log and Annotate provided by IDE it needs more research.

zielu avatar Mar 16 '20 07:03 zielu

github Here actually :tada: shows as text and not as a emoji. I think its inline blame

  • [ ] inline blame

itspooya avatar Mar 16 '20 09:03 itspooya

Research results:

  • to show them in inline blame implementation would need to switch to com.intellij.openapi.editor.impl.InlayModelImpl#getAfterLineEndElementsForLogicalLine

zielu avatar Mar 16 '20 11:03 zielu

Note to self - try replacing gitmoji text with unicode for example alembic : https://emojipedia.org/emoji/⚗/

See https://blog.jetbrains.com/idea/2020/06/intellij-idea-2020-2-eap2-is-here-with-advanced-exception-stack-trace-analysis-emoji-support-on-linux-and-more/?utm_source=product&utm_medium=link&utm_campaign=TBA for reference

zielu avatar Jun 04 '20 15:06 zielu

Possible because #268 is done

zielu avatar Aug 05 '21 19:08 zielu

Possible because #268 is done image

No completion in Commit dialog. IDEA Version: 2021.2.3

scruel avatar Nov 03 '21 14:11 scruel

@scruel not related - missing completion in non-modal dialog is a separate isssue.

I created #355 to track it

zielu avatar Nov 03 '21 15:11 zielu

@scruel not related - missing completion in non-modal dialog is a separate isssue.

I created #355 to track it

Ok, I was thought that my issue may same as 'gitmoji not showing', and I noticed you mentioned you provide completion in commit dialog(https://github.com/zielu/GitToolBox/issues/220#issuecomment-599383442), so I post it here, sorry for the inconvenience!

scruel avatar Nov 05 '21 00:11 scruel